Use global URL constructor #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samclarke
approved these changes
Jan 7, 2022
|
Thanks for the PR! I wasn't aware that URL had been added as a global variable. As all currently supported versions of Node include it as a global variable and have for a while now, it would make sense to use it that way, especially if it makes some use cases easier. |
|
Yes, definitely not essential, but nice to have. Thanks for taking a look so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A much later follow-up to #8 :)
We're still happy
robots-parserusers over in GoogleChrome/lighthouse. Recently we've been changing how we bundle Lighthouse for use in the browser, and, for whatever reason, the most popular rollup and browserify polyfills for the Node'url'module don't include theURLproperty, requiring an extra level of patching to getrobots-parserworking in the browser.Node 10 added
URLas a global, though, which was released long enough ago that maybe the explicitrequire()could be dropped and the global used instead?Thanks!