docs: fix broken benchmark link in README - #965
Open
latent-9 wants to merge 1 commit into
Open
Conversation
The "See the full implementation" link pointed to `./map_benchmark_test.go`, which no longer exists at the repo root (the root test files were relocated in samber#719). The map benchmarks now live in `benchmark/core_map_bench_test.go`, so this repoints the link there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README links the map benchmark implementation:
map_benchmark_test.gono longer exists at the repo root, so the link 404s. The root test files were moved out in #719 ("reduce the number of files in root directory"), and the map benchmarks now live inbenchmark/core_map_bench_test.go. This repoints the link there.