Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the case where the second slice has duplicate elements #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maratrixx
Copy link

@maratrixx maratrixx commented Mar 20, 2022

Description (what this PR does / why we need it):

For the case below:

Union[int]([]int{0, 1, 2}, []int{0, 1, 2, 3, 3})

the output now is:

[0, 1, 2, 3, 3]

and should be:

[0, 1, 2, 3]

What this PR fixes (resolves / be part of):

  • fix: fix the case where the second list has duplicate elements.
  • feat: add memory prealloc.
  • style: code format.

Other special notes for reviewer:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant