test-info.yml changes #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synarete
reviewed
Mar 24, 2024
Collaborator
synarete
left a comment
synarete
left a comment
There was a problem hiding this comment.
The overall logic is fine, but needs a bit of (Python style) cleanups.
We do not use this section in any of our current tests and I don't forsee the need for this in the near future. Signed-off-by: Sachin Prabhu <sp@spui.uk>
Avoid directly accessing the test_info dict and use helper function instead. This will allow us to modify the test_info.yml with minimal disruption. Signed-off-by: Sachin Prabhu <sp@spui.uk>
spuiuk
force-pushed
the
test-info.changes
branch
3 times, most recently
from
5290051 to
4942b83
Compare
selftest/test_testhelper.py
Outdated
| testinfo = testhelper.read_yaml("test-info1.yml") | ||
| arr = [] | ||
| for share in testhelper.get_exported_shares(testinfo): | ||
| s = testhelper.get_share(testinfo, share) |
Collaborator
There was a problem hiding this comment.
I am not very comfortable with one letter variable name, I would vote for something more descriptive like share_info
Collaborator
Author
There was a problem hiding this comment.
I have made the changes.
Collaborator
There was a problem hiding this comment.
Thanks for the update, I still see some occurrences of 's' in testhelper/testhelper.py
Please see if all such occurrences can be updated as well.
Collaborator
Author
There was a problem hiding this comment.
Yes. but not in this set of changes.
spuiuk
force-pushed
the
test-info.changes
branch
from
4942b83 to
7b4ebd9
Compare
synarete
reviewed
Mar 25, 2024
Collaborator
synarete
left a comment
synarete
left a comment
There was a problem hiding this comment.
Looks fine, but few style issues.
spuiuk
force-pushed
the
test-info.changes
branch
from
7b4ebd9 to
3176e52
Compare
Change the way we list shares in test-info.yml
This will be used to add additional functionality to tests.
eg:
shares:
# share name export1
export1:
# If present, it means the share is pre-mounted
path: /mnt/share/export1-cephfs-vfs
backend:
# If present backend filesystem
name: cephfs.vfs
# If present, username to perform the tests with on this share
users:
test2: x
# If present, the hostname to use to connect to the test server
server: hostname1
export2:
This commit still supports the old format of test-info.yml. The new
changes deprecates the old test-info.yml format which can be removed
once the sit-environment has been updated.
Signed-off-by: Sachin Prabhu <sp@spui.uk>
With the latest updates to testhelper, the complexity of the helper code has increased and there is now a good case for adding selftests to ensure that the helper code works as expected. We start by creating a few simple tests for the code in testhelper/testhelper.py. Signed-off-by: Sachin Prabhu <sp@spui.uk>
spuiuk
force-pushed
the
test-info.changes
branch
from
3176e52 to
62170d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this set of changes out of PR #63.
These commits change the way we describe shares in test-info.yml file.
These changes will allow for us to set server, backend fs type and users for each individual share. This means that shares across multiple smb shares and filesystems can be tested at the same time.
With these changes, we can still continue using the old format to describe test-info.yml but they will be deprecated and removed once we have made the changes to the sit-environment to use the new format.