add files to include in smb.conf stub for ctdb #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was working because we had a newline before the next section header but this can break if you insert a new param after the 'nodes list' param. I found it when prototyping something I am not going to use after all, but the fix here is still worthwhile. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
When using ctdb most of the configuration should be managed via the registry config via ctdb. However, there are some parameters you may need to be per-instance. As a quick and simple way of getting custom per host settings with ctdb allow for including additional files from the generated stub smb.conf file. Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
requested review from
spuiuk,
xhernandez,
anoopcs9 and
avanthakkar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ctdb most of the configuration should be managed via the
registry config via ctdb. However, there are some parameters you may
need to be per-instance. As a quick and simple way of getting custom
per host settings with ctdb allow for including additional files from
the generated stub smb.conf file.
Plus two minor cleanups noticed while hacking on this feature.