Create services for access to servers #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
NOTE: This PR is a draft because it requires the work in PR #50 - as it currently stands the new tests are tested against the "latest" tag of the quay.io repo - not the changes in this PR! |
raghavendra-talur
requested changes
Apr 28, 2021
Collaborator
raghavendra-talur
left a comment
raghavendra-talur
left a comment
There was a problem hiding this comment.
Except for one small change, everything else looks very good!
The ServerGroup determines the name of the server (or group of servers) actually hosting the share. Today it is a 1:1 relationship but may not always be so. Add this operator determined value to the status of the SmbShare resource. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Previously, we were just using the name of the SmbShare. Now we use the derived (but often the same value) server group name. Signed-off-by: John Mulligan <jmulligan@redhat.com>
The share label is either meaningless or worse, misleading. Remove it from the set of labels the operator applies to the deployment. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Allow the operator to configure services that go along with a share. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Add a function to support creating a service that can be used to access the pod and port 455 hosting an smb share. Signed-off-by: John Mulligan <jmulligan@redhat.com>
After creating the deployment, create a service that exposes port 445 and matches the label specific to the share's server group. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Use the in-cluster dns to access a share by the name of the service that gets created by the operator. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-servers-services
branch
from
7d5b490 to
5fd2deb
Compare
Collaborator
Author
|
@raghavendra-talur or @obnoxxx PTAL. We'll need this as a starting point for future work. |
raghavendra-talur
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the patches define & name a Server Group concept, implied as part of the Phase 1 design doc. This is the name of smb server (or group of servers) hosting the share defined by a SmbShare resource.
Then this name is used to properly label and create kubernetes Services to expose port 445 for the instance.
A new test case, using the k8s internal dns name for the service is added.