Uniquify requisite_in'd states checks.

[gpernot-celeste]

Fixes #68408

Introduce _add_to_extend for small factorization.

The logic here is to prevent to append dependencies that are already in extend[name][rstate][ind][rkey] :

for key in extend[name][rstate][ind][rkey]:
  if key.get(state) == id_:
    break

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Salt's Contributor Guide
• Join our Community Discord
• Salt Project YouTube channel
• GitHub Discussions

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject.pdl@broadcom.com. We're glad you've joined our community and look forward to doing awesome things with you!

[bdrx312]

Thanks for the PR; please add tests.

[gpernot-celeste]

@bdrx312 Thanks for your review !

I added simplified code and unit tests.

[bdrx312]

Thanks for the PR. Nice changes.

[gpernot-celeste]

Thanks for the PR. Nice changes.

Thanks :)

It was buggy, but i now believe that the code is correct.

Should I rebase/squash on 3006.x ?

[dwoz]

• This needs a changelog.
• I'm super concerned that this could fix a bug and introduce others.

[gpernot-celeste]

@dwoz changelog added.

I tried my best with unit tests to avoid introducing bugs.

Moreover, unit tests on check_requisite() should trigger regressions, if any.

[twangboy]

Perhaps a functional or integration test, to provide a more thorough test.

[twangboy]

Please rebase and fix conflicts