[3006.x] Fix parallel state execution with Salt-SSH #66517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
bdrx312
reviewed
May 16, 2024
dwoz
requested changes
Jun 21, 2024
dwoz
approved these changes
Jul 17, 2024
twangboy
approved these changes
Jul 18, 2024
lkubb
added a commit
to lkubb/salt
that referenced
this pull request
Oct 24, 2024
This was introduced by saltstack#66517 `__invocation_jid` is rewriten to `_State__invocation_id`, making `cls(**init_kwargs)` fail with a TypeError (unexpected argument `__invocation_jid` (this behavior is called name mangling).
3 tasks
lkubb
added a commit
to lkubb/salt
that referenced
this pull request
Oct 24, 2024
This was introduced by saltstack#66517 `__invocation_jid` is rewriten to `_State__invocation_id`, making `cls(**init_kwargs)` fail with a TypeError (unexpected argument `__invocation_jid` (this behavior is called name mangling).
lkubb
added a commit
to lkubb/salt
that referenced
this pull request
Oct 24, 2024
This was introduced by saltstack#66517 `__invocation_jid` is rewriten to `_State__invocation_id`, making `cls(**init_kwargs)` fail with a TypeError (unexpected argument `__invocation_jid` (this behavior is called name mangling).
dwoz
pushed a commit
that referenced
this pull request
Oct 25, 2024
This was introduced by #66517 `__invocation_jid` is rewriten to `_State__invocation_id`, making `cls(**init_kwargs)` fail with a TypeError (unexpected argument `__invocation_jid` (this behavior is called name mangling).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a TypeError that was raised when executing parallel states via Salt-SSH (jid was unset, but the cache dir used for returning the result of a parallel execution depended on it).
What issues does this PR fix or reference?
Fixes: #66514
Fixes: #53538
Previous Behavior
Exits with retcode=0, shows
sys.docofstate.pkgbecause of a TypeError (on <3007) / at least errors with retcode=1 and shows the stacktrace (>=3007).New Behavior
Executes the states in parallel as requested.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes