64015 Port get_all_groups within boto_asg.get_config to boto3
#64080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binocvlar
changed the title
get_all_groups within boto_asg.get_config to boto3
|
Hi @s0undt3ch - can you please take a look at this PR and let me know if there's anything that I can do to expedite its completion? |
It needs tests for the changes made. |
s0undt3ch
added
the
Needs-Testcase
Replace all calls to `get_all_groups` with a boto3 equivalent implementation. This change is being made to address the breakage highlighted in issue saltstack#64015. Note that this port doesn't touch any of the other uses of boto which still appear to be functioning correctly. These should probably be tackled as a matter of priority though.
s0undt3ch
force-pushed
the
64015_port_get_all_groups_calls_to_boto3
branch
from
5c3d9e2
to
5245034
Compare
Hi @s0undt3ch - I've just attempted to update my PR with a simple testcase, only to find that a suitable test is already there i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace calls to
get_all_groupswithinget_configwith aboto3equivalent implementation. This change is being made to address the breakage highlighted in issue #64015.Note that this port doesn't touch any of the other uses of
botowhich still appear to be functioning correctly. These should probably be tackled as a matter of priority though.What does this PR do?
What issues does this PR fix or reference?
Fixes: 64015
Previous Behavior
Module was broken as a result of changed
get_all_groupsbehaviour.New Behavior
No longer broken, and compatible with previous implementation (expected key names are translated to preserve previous contract).
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
I don't have the time to write a brand new set of tests for
boto_asg.py- perhaps this PR could serve as the starting point for someone who does?Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.