-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
64015 Port get_all_groups
within boto_asg.get_config
to boto3
#64080
base: master
Are you sure you want to change the base?
64015 Port get_all_groups
within boto_asg.get_config
to boto3
#64080
Conversation
get_all_groups
within boto_asg.get_config
to boto3
Hi @s0undt3ch - can you please take a look at this PR and let me know if there's anything that I can do to expedite its completion? |
It needs tests for the changes made. |
Replace all calls to `get_all_groups` with a boto3 equivalent implementation. This change is being made to address the breakage highlighted in issue saltstack#64015. Note that this port doesn't touch any of the other uses of boto which still appear to be functioning correctly. These should probably be tackled as a matter of priority though.
5c3d9e2
to
5245034
Compare
Hi @s0undt3ch - I've just attempted to update my PR with a simple testcase, only to find that a suitable test is already there i.e. |
Replace calls to
get_all_groups
withinget_config
with aboto3
equivalent implementation. This change is being made to address the breakage highlighted in issue #64015.Note that this port doesn't touch any of the other uses of
boto
which still appear to be functioning correctly. These should probably be tackled as a matter of priority though.What does this PR do?
What issues does this PR fix or reference?
Fixes: 64015
Previous Behavior
Module was broken as a result of changed
get_all_groups
behaviour.New Behavior
No longer broken, and compatible with previous implementation (expected key names are translated to preserve previous contract).
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
I don't have the time to write a brand new set of tests for
boto_asg.py
- perhaps this PR could serve as the starting point for someone who does?Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.