Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EndeavourOS os_family #62220

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Add EndeavourOS os_family #62220

merged 3 commits into from
Sep 30, 2022

Conversation

droogmic
Copy link
Contributor

EndeavourOS is an Arch family OS.

What does this PR do?

Add support for EndeavourOS is OS Family Map

Previous Behavior

$ sudo salt 'os:EndeavourOS' grains.get os_family
foobar:
    EndeavourOS

New Behavior

$ sudo salt 'os:EndeavourOS' grains.get os_family
foobar:
    Arch

Merge requirements satisfied?

Commits signed with GPG?

Yes

@droogmic droogmic requested a review from a team as a code owner June 26, 2022 13:59
@droogmic droogmic requested review from MKLeb and removed request for a team June 26, 2022 13:59
@welcome
Copy link

welcome bot commented Jun 26, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@droogmic droogmic force-pushed the patch-1 branch 2 times, most recently from 5997f2c to 9d09c5f Compare July 9, 2022 07:06
EndeavourOS is an Arch family OS.
@MKLeb
Copy link
Contributor

MKLeb commented Sep 13, 2022

Hi @droogmic , this will need tests and a changelog. Thanks for your contribution!

@MKLeb MKLeb added Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases needs-changelog-file labels Sep 13, 2022
@garethgreenaway garethgreenaway removed Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases needs-changelog-file labels Sep 30, 2022
@garethgreenaway garethgreenaway merged commit 6aa72a4 into saltstack:master Sep 30, 2022
@welcome
Copy link

welcome bot commented Sep 30, 2022

Congratulations on your first PR being merged! 🎉

@bdrung
Copy link
Contributor

bdrung commented Sep 30, 2022

The added test case is broken due to my recent changes in the grains code. Can you update the test case? If not, can you provide the content of /etc/os-release? Then I can fix the test case.

@bdrung
Copy link
Contributor

bdrung commented Sep 30, 2022

Commit dab8ea5 changed the parameters for _run_os_grains_tests.

@garethgreenaway
Copy link
Contributor

This should fix things #62790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants