Add log_utc option to sqlite3 returner #58003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging non-utc timestamps creates obvious problems for any system that has a timezone configured. It should at least be possible to use UTC timestamps in the returner output.
ghost
requested review from
cmcmarrow
added
the
Needs-Testcase
|
@nathansgreen thanks for the PR! I agree that people will benefit from |
|
There's not much in the way of existing tests for returners, but I'll try to cook something up. It's hard to see a good way to test this without a lot of scaffolding. |
|
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging non-utc timestamps creates obvious problems for any system
that has a timezone configured. It should at least be possible to
use UTC timestamps in the returner output.
What does this PR do?
Add a
log_utcoption to the sqlite3 returner. This enables UTC as the logged timestamp.What issues does this PR fix or reference?
Fixes: 58002
Previous Behavior
Always logs local time.
New Behavior
If enabled, logs in UTC.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.