[WIP] Porting Async Batch #50546 #55268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
dincamihai
force-pushed
the
saltstack-PR#50546
branch
from
cc0eb6a
to
4d89764
Compare
4 tasks
dincamihai
force-pushed
the
saltstack-PR#50546
branch
2 times, most recently
from
6cd7942
to
7453d7e
Compare
added 24 commits
December 18, 2019 16:09
- start batching immediatelly after all minions reply to ping - return jid, available minions and missing minions in the response - fire event when batching start and when it ends
added 7 commits
December 18, 2019 16:09
dincamihai
force-pushed
the
saltstack-PR#50546
branch
from
7453d7e
to
ad55f40
Compare
waynew
reviewed
Dec 27, 2019
There was a problem hiding this comment.
Hey @dincamihai this is looking great - it's labeled [WIP], what else is needed here?
|
@dincamihai could you please update the status of this? |
|
@DmitryKuzmenko This had some memory issues and I can't tell if this has all the fixes. @meaksh could you add the missing patches on top of this? Thanks! |
|
@dincamihai thank you for update. There are also lint failures. |
|
@dincamihai @meaksh any chance to get an update on this? |
|
Heya. Any update on this? It would be super-helpful to be able to run async jobs in batches... |
|
Closing this due to inactivity. Anyone should feel free to re-open it they want to see it through to the end in a release cycle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Porting Async Batch #50546
Tests written?
Yes
Commits signed with GPG?
No