Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added refs to AIX module documentation #53369

Merged
merged 21 commits into from
Jun 17, 2019
Merged

Conversation

Akm0d
Copy link
Contributor

@Akm0d Akm0d commented Jun 4, 2019

What does this PR do?

Add ref to documentation for AIX

What issues does this PR fix or reference?

#53333

Commits signed with GPG?

Yes

@Akm0d Akm0d requested a review from bryceml June 4, 2019 19:09
Copy link
Contributor

@bryceml bryceml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bryceml@a905c28

you have to add it to the index too.

@bryceml
Copy link
Contributor

bryceml commented Jun 4, 2019

I wasn't very through on the commit I posted above, so there might be additional changes as well.

@Akm0d
Copy link
Contributor Author

Akm0d commented Jun 4, 2019

Got it, anywhere else we might need a change? Is My description of AIX pkg correct?

@mchugh19
Copy link
Contributor

mchugh19 commented Jun 4, 2019

Likely part of #52368 as well

@Akm0d
Copy link
Contributor Author

Akm0d commented Jun 5, 2019

Likely part of #52368 as well

Looks like most of it is similar. There are some change to the index and such seem to be unique to this PR

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #53369 into 2019.2.1 will increase coverage by 23.63%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           2019.2.1   #53369       +/-   ##
=============================================
+ Coverage     13.41%   37.04%   +23.63%     
=============================================
  Files          1520     1576       +56     
  Lines        252471   269530    +17059     
  Branches      53842    57450     +3608     
=============================================
+ Hits          33862    99859    +65997     
+ Misses       215833   158417    -57416     
- Partials       2776    11254     +8478
Flag Coverage Δ
#arch ?
#centos7 ?
#debian8 36.65% <ø> (?)
#debian9 36.44% <ø> (?)
#proxy ?
#py2 36.84% <ø> (+23.56%) ⬆️
#py3 35.63% <ø> (+22.53%) ⬆️
#ubuntu1604 36.8% <ø> (+31.81%) ⬆️
#ubuntu1804 36.47% <ø> (?)
Impacted Files Coverage Δ
salt/proxy/dummy.py 0% <0%> (-80.87%) ⬇️
salt/proxy/docker.py 0% <0%> (-62.5%) ⬇️
salt/proxy/chronos.py 0% <0%> (-50%) ⬇️
salt/proxy/marathon.py 0% <0%> (-50%) ⬇️
salt/proxy/cisconso.py 0% <0%> (-46.43%) ⬇️
salt/proxy/arista_pyeapi.py 0% <0%> (-45.66%) ⬇️
salt/proxy/nxos_api.py 0% <0%> (-44.74%) ⬇️
salt/proxy/rest_sample.py 0% <0%> (-38.38%) ⬇️
salt/cloud/clouds/linode.py 13.58% <0%> (-36.34%) ⬇️
salt/modules/dummyproxy_service.py 46.15% <0%> (-35.9%) ⬇️
... and 1171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d806b58...0ef9892. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #53369 into 2019.2.1 will increase coverage by 23.63%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           2019.2.1   #53369       +/-   ##
=============================================
+ Coverage     13.41%   37.04%   +23.63%     
=============================================
  Files          1520     1576       +56     
  Lines        252471   269530    +17059     
  Branches      53842    57450     +3608     
=============================================
+ Hits          33862    99859    +65997     
+ Misses       215833   158417    -57416     
- Partials       2776    11254     +8478
Flag Coverage Δ
#arch ?
#centos7 ?
#debian8 36.65% <ø> (?)
#debian9 36.44% <ø> (?)
#proxy ?
#py2 36.84% <ø> (+23.56%) ⬆️
#py3 35.63% <ø> (+22.53%) ⬆️
#ubuntu1604 36.8% <ø> (+31.81%) ⬆️
#ubuntu1804 36.47% <ø> (?)
Impacted Files Coverage Δ
salt/proxy/dummy.py 0% <0%> (-80.87%) ⬇️
salt/proxy/docker.py 0% <0%> (-62.5%) ⬇️
salt/proxy/chronos.py 0% <0%> (-50%) ⬇️
salt/proxy/marathon.py 0% <0%> (-50%) ⬇️
salt/proxy/cisconso.py 0% <0%> (-46.43%) ⬇️
salt/proxy/arista_pyeapi.py 0% <0%> (-45.66%) ⬇️
salt/proxy/nxos_api.py 0% <0%> (-44.74%) ⬇️
salt/proxy/rest_sample.py 0% <0%> (-38.38%) ⬇️
salt/cloud/clouds/linode.py 13.58% <0%> (-36.34%) ⬇️
salt/modules/dummyproxy_service.py 46.15% <0%> (-35.9%) ⬇️
... and 1171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d806b58...0ef9892. Read the comment docs.

@garethgreenaway garethgreenaway self-requested a review June 17, 2019 20:21
@garethgreenaway garethgreenaway requested a review from a team June 17, 2019 20:21
@Akm0d Akm0d merged commit ff7370e into saltstack:2019.2.1 Jun 17, 2019
@Akm0d Akm0d deleted the aix_docs branch June 17, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants