Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Removed reliance on LegacyVersion from pkg_resources can break pip modules #66686

Open
Legrems opened this issue Jul 3, 2024 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior needs-triage

Comments

@Legrems
Copy link

Legrems commented Jul 3, 2024

Description
This PR [https://github.com/pypa/setuptools/pull/2822] remove the reliance on LegacyVersion.

Since then, the pip modules could be broken, if there is an InvalidVersion (before, it was only a LegacyVersion) on the pip repo you're using.

Since we were using a custom pip repo (mirror + some custom packages), with some old version, some method on the pip modules would not work. In particular:

  • pip.list_all_versions
  • pip.installed (this call pip.list_all_versions)
  • Probably some others method that call pip.list_all_versions

Setup
Nothing really specific to salt.

Steps to Reproduce the behavior
Have an invalid version in the pip repo history, and then you can't even install the current latest version (which could be valid), since the list_all_versions is failing due to this.

Expected behavior
At least ignore the non-standard version, except of failing completly

Versions Report
3006.8

I will provide a PR soon, since it was quite critical (and we couldn't remove the package from the repo)

@Legrems Legrems added Bug broken, incorrect, or confusing behavior needs-triage labels Jul 3, 2024
Copy link

welcome bot commented Jul 3, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior needs-triage
Projects
None yet
Development

No branches or pull requests

1 participant