Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nmap version update 7.01 #184

Merged
merged 3 commits into from Dec 28, 2015
Merged

Nmap version update 7.01 #184

merged 3 commits into from Dec 28, 2015

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2015

  • Updated version
  • combined into for-loop
  • Fixed typo in uninstaller

1.) Updated nmap version to 7.01.
2.) Uses for-loop for both versions.
3.) Fixed typo for uninstaller.

Info: Provides silent installer Winpcap (usable e.g. for wireshark).
@TheBigBear
Copy link
Contributor

@gqgunhed have you tested this?
In the past the nmap installer did NOT set the version number in the DisplayVersion field in the uninstaller key in the registry, and consequently the winrepo installer only ever found version "Not Found", which makes it impossible to have a sls file for more than one version that actually works.
The 'best' workaround in this case is probably to always have the winrepo installer sls file only ever point to the latest released version of nmap instead.

@ghost
Copy link
Author

ghost commented Dec 27, 2015

@TheBigBear I tested installing by pkg.install and removing with pkg.purge (without specific version). As far as I remember it is possible that it showed only "Not Found" as "old:" at the time of removing.
So maybe it's better to keep only the latest version in the file.
You have by far more experience with those installers than me :-)

@ghost
Copy link
Author

ghost commented Dec 28, 2015

@TheBigBear so should I edit the nmap sls to only include the latest version?

@TheBigBear
Copy link
Contributor

Yes, please do, I just double checked, and even the most up-to-date version of the 7.x series of nmap still does not set the windows unistall "DisplayVersion" registry key as it should.

nmap-7 x-no-windows-registry-uninstall-displayversion-set

@TheBigBear
Copy link
Contributor

have added upstream PR on nmap project
nmap/nmap#263

@ghost
Copy link
Author

ghost commented Dec 28, 2015

very cool :-) I used the old 6.47 sls and just replaced 6.47 with 7.01.

@TheBigBear
Copy link
Contributor

@gqgunhed thanks. and once the upstream nmap windows installer has added the version number we can then add a few versions into a 'for' loop, as planned.

TheBigBear added a commit that referenced this pull request Dec 28, 2015
@TheBigBear TheBigBear merged commit da6acb2 into saltstack:master Dec 28, 2015
@ghost ghost deleted the nmap-version branch December 29, 2015 12:23
TheBigBear added a commit that referenced this pull request Mar 7, 2016
Merge pull request #323 from TheBigBear/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants