Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions for atom, libreoffice, npp #1726

Closed
wants to merge 5 commits into from

Conversation

akoscomp
Copy link
Contributor

Add atom 1.51.0 version
Add libreoffice 6.4.7.2 version
Add npp 7.9 version

akos and others added 5 commits October 10, 2020 16:07
change installer path to github
Notepad++ switched to github and is seams that the old repo was removed. On github the latest version is 7.7.
add 81.0.1 version
add 81.0.1 version
@@ -5,11 +5,10 @@
{% set PROGRAM_FILES = "%ProgramFiles%" %}
{% endif %}
npp:
{% for version in ['7.7.1', '7.7', '7.6.6', '7.6.4', '7.6.3', '7.6.2', '7.6.1', '7.5.9', '7.5.8', '7.5.7', '7.5.6', '7.5.5', '7.5.4', '7.5.3', '7.5.2', '7.5.1', '7.4.2'] %}
{% set maj_version = version[0] ~ '.x' %}
{% for version in ['7.9', '7.8.9', '7.7.1', '7.7'] %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove the older versions. Salt still needs to know how to uninstall those.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to break this up into multiple PRs so the NPP changes aren't holding up the rest of the changes you want to make.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to keep the old versions, but the the github verification process was crashed, because the old npp source became unavailable. In the new source (github) the oldest version was 7.7.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akoscomp sorry to have stepped on your PR. I have done it now, the travisci test have an option to be skipped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@didiatworkz
Copy link
Contributor

firefox version deprecated #1746
npp version deprecated #1762
atom version deprecated #1740
libreoffice version deprecated #1763

@twangboy
Copy link
Collaborator

Looks like we have some merge conflicts

@akoscomp
Copy link
Contributor Author

All versions become deprecated, I close the pull request.

@akoscomp akoscomp closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants