Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(macos): updated pillar.example & hashsum #250

Merged
merged 1 commit into from
Jul 31, 2020
Merged

docs(macos): updated pillar.example & hashsum #250

merged 1 commit into from
Jul 31, 2020

Conversation

noelmcloughlin
Copy link
Member

@noelmcloughlin noelmcloughlin commented Jul 26, 2020 •
edited
Loading

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

These are updates for macos

  • Add example to pillar.example
  • Remove some old stuff from pillar.example
  • update hashsum in osfamilymap (note: using pillar data for hashsum is better but no harm)

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@pull-assistant
Copy link

pull-assistant bot commented Jul 26, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     docs(macos): updated pillar.example & macos hash

Powered by Pull Assistant. Last update fc011b3 ... fc011b3. Read the comment docs.

@noelmcloughlin
Copy link
Member Author

Selfie updating as doc/macOS update only

@noelmcloughlin noelmcloughlin merged commit 9b8b16e into saltstack-formulas:master Jul 31, 2020
@noelmcloughlin noelmcloughlin deleted the macos branch July 31, 2020 14:33
myii added a commit that referenced this pull request Sep 23, 2020
@myii
fix(pillar.example): fix yamllint violation [skip ci]
31087af 
* #250
@myii
Copy link
Member

myii commented Sep 23, 2020

@noelmcloughlin This introduced a yamllint error in the pillar.example -- fixed in 31087af.

@noelmcloughlin
Copy link
Member Author

Okay, sorry about that @myii

@myii
Copy link
Member

myii commented Sep 23, 2020

Okay, sorry about that @myii

@noelmcloughlin No problem, we're just working through adding pre-commit to all of the repos and this one kept failing until I had to dig down further. You can use your GitHub integration to see how we're getting along:

This is the actual PR being worked on to get all of this done:

saltstack-formulas-travis pushed a commit that referenced this pull request Nov 18, 2020
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
f89b189 
# [1.0.0](v0.44.0...v1.0.0) (2020-11-18)

### Bug Fixes

* **cent7:** install yum-plugin-versionlock too ([3b2e237](3b2e237))
* **clean:** do not remove python package ([e7ee880](e7ee880))
* **pillar.example:** fix `yamllint` violation [skip ci] ([31087af](31087af)), closes [#250](#250)
* **state:** corrected remove state ([e178243](e178243))

### Code Refactoring

* **rewrite:** modernize formula and fresh start ([1e48667](1e48667)), closes [#252](#252) [#249](#249) [#243](#243) [#236](#236) [#234](#234) [#219](#219) [#202](#202) [#191](#191) [#190](#190) [#160](#160) [#95](#95) [#85](#85) [#74](#74) [#251](#251) [#253](#253)

### Continuous Integration

* **kitchen:** use `saltimages` Docker Hub where available [skip ci] ([1755f38](1755f38))
* **pre-commit:** add to formula [skip ci] ([d04e24a](d04e24a))
* **pre-commit:** enable/disable `rstcheck` as relevant [skip ci] ([8454e4a](8454e4a))
* **pre-commit:** finalise `rstcheck` configuration [skip ci] ([87c737c](87c737c))
* **travis:** add notifications => zulip [skip ci] ([6222d60](6222d60))

### Documentation

* **macos:** updated pillar.example & macos hash ([fc011b3](fc011b3))
* **readme:** fix macos clean state ([fca7fea](fca7fea))

### BREAKING CHANGES

* **rewrite:** This version is not backwards compatible. Update
 your states and pillar data to align with new formula.

 - MacOS was not tested in this PR but hopefully no regression.
 - docker.containers: sls was simplified (raise PR if regression)
@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noelmcloughlin @myii @saltstack-formulas-travis