Conversation
Fixes: #77 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
Fixed typo in settings definitions.
Fix a typo: Canot -> Cannot
…written_missing_reference Fix ignore_overwritten_missing_reference default
added support for .yaml along with .yml
…Error These are parent classes for other error classes which all pass the msg parameter as an optional parameter.
…me or node file path By default a class mapping will match against the name of a node: class_mappings: - test* alpha This will match all nodes names starting with test. A possibly unintended side effect of the original implementation allowed for matches against the path of the node file. So for a node file 'test/node1.yml' a match: class_mappings: - test/* alpha would work. A reworking of the class mappings implementation ment this matching stopped working. The type of matching done by the class mapping is now controlled by the configuration option class_mappings_match_path. If false (the default) the match is done against the node name and if true the match is done again the path.
Fix doc for ignore_class_notfound_regexp
add Python3.7 compatibility
…regression allow class mappings to match on node name or node path
fix yaml git error reporting
…rect data With two indentical inventory queries, one with the AllEnvs flag and one without both queries return the data from the query with the AllEnvs flag set. This fix adds a test to the invitem class when assembling the inventory query result to check that the node environments match or that the query has the AllEnvs flag set.
…riting Fix identical inventory queries with different flags returning incorrect data
so that with the following reclass config:
```
=> /etc/reclass/nodes/mynode.yml
classes:
- common
parameters:
project: myproject
=> /etc/reclass/classes/common.yml
class:
- ${project}
=> /etc/reclass/classes/myproject.yml
parameters:
some:
project: parameters
```
The mynode parameters would be merged successfully by reclass and we will
get the following result for the parameters:
```
parameters:
project: myproject
some:
project: parameters
```
Without this patch, this would result in the following error:
```
Failed to load ext_pillar reclass: ext_pillar.reclass: -> mynode
In yaml_fs:///etc/reclass/classes/common.yml
Class name ${project} not resolvable
```
so that we avoid side effect of list elements being merged twice in the same list. This commit adds a new "scalar_parameters" reclass config option (defaults to False) used to indicate where to find scalar parameters in node parameters dict.
Add support to use current node parameters as references in class name
Signed-off-by: Petr Michalec <epcim@apealive.net>
bump version 1.7.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After all since 2018 there are some changes worth of 1.7 release.
Features:
and few but important fixes
would not be possible without contribution of @AndrewPickford @bbinet @pranavgupta1234 and few others on a list below. Thanks.