Fix: use returned parameter from _render_simple_dict/list in exports class#55
Merged
Fix: use returned parameter from _render_simple_dict/list in exports class#55
Conversation
…class The Parameters._render_simple_dict and _render_simple_list methods now return a new dict or list instead of changing in place the dict or list passed to them. This commit updates the exports class appropriately and adds some additional tests for these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Parameters._render_simple_dict and _render_simple_list methods now (see #52)
return a new dict or list instead of changing in place the dict or list
passed to them. This commit updates the exports class appropriately and
adds some additional tests for these changes.