-
Notifications
You must be signed in to change notification settings - Fork 184
Open
Labels
s: pending triagePending TriagePending Triage
Description
Description
Discovered that migrationsTable
was actually a required property when converting some JavaScript files to TypeScript.
I had been calling runner()
without providing migrationsTable
and it seemed to work fine:
await runner({
dbClient: dbClient,
dir: 'db/migrations',
direction: 'up',
})
Behind the scenes I expected it was using the default value of "pgmigrations"
, same as the CLI.
It was actually coercing the missing value to a string and creating a migrations table named "undefined"
. Probably not harmful (it certainly wasn't in my case), but a little surprising. Feels more like an unexpected side-effect than a deliberate choice.
Suggested solution
Either
- Default to
"pgmigrations"
, similar to CLI. Argument against this here (#544). - Throw an error if
migrationsTable
is missing.
Alternative
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
s: pending triagePending TriagePending Triage