Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Avro v1.12 #71

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add support for Avro v1.12 #71

merged 1 commit into from
Aug 5, 2024

Conversation

tjwp
Copy link
Collaborator

@tjwp tjwp commented Aug 5, 2024

A new major release of Avro was pushed today. This change updates the gemspec to allow the new version and adds an appraisal for it.

There is not much new functionality for Ruby in this release, but some bug fixes. Support for the timestamp-nanos logical type was added to Ruby Avro. avro-builder was already permissive with regard to specifying logical types that do not require additional attributes, but since this is now an officially supported logical type I added a spec similar to the existing -millis and -micros specs.

Maybe it is time for this gem to drop support for Ruby 2.7? I have not made that change here.

@tjwp tjwp requested a review from a team as a code owner August 5, 2024 18:53
Copy link
Contributor

@gremerritt gremerritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's go ahead and release this as-is - if tests are passing, might as well keep official 2.7 support for it? Then follow up with a major version bump dropping 2.7?

@tjwp tjwp merged commit 3a780b8 into master Aug 5, 2024
2 checks passed
@tjwp tjwp deleted the tjwp/avro-1.12 branch August 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants