Use MultiJson to encode schemas #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturkel
approved these changes
Feb 11, 2021
|
Looks like this project is still on Travis and having some build issues. I'll put up a PR shortly to migrate over to CircleCI. |
|
See #57 for the CircleCI migration (and some dependency upgrades). |
|
Will rebase this once the CI migration has been merged. |
tjwp
force-pushed
the
tjwp-multi-json
branch
from
4019999
to
ec44ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of avro-builder rely on the
jsongem being loaded without explicitly requiring it. Behavior changed somewhere between ruby 2.6.2 and ruby 2.6.5 so thatjsonis no longer loaded without an explicit require.One option would be to
require 'json'but theavrogem already depends onmulti_json. Sincemulti_jsonis now referenced directly it is declared as a dependency here, but should also be present for any current users of the gem.Using
multi_jsonprovides more flexibility for users of the gem, and makes the JSON encoding code here slightly cleaner.Fixes #55