Skip to content

Conversation

@ibraheemdev
Copy link
Member

@ibraheemdev ibraheemdev commented Aug 12, 2025

This improves codegen, but not sure it'll have a measurable impact:

- hash_one_id:
- 	mov eax, dword ptr [rdi]
- 	mov ecx, dword ptr [rdi + 4]
- 	movabs rdx, -1065810590584100411
- 	imul rax, rdx
- 	add rax, rcx
- 	imul rax, rdx
- 	rol rax, 26
-   ret

+ hash_one_id:
+ 	movabs rax, -1065810590584100411
+ 	imul rax, qword ptr [rdi]
+ 	rol rax, 26
+   ret

@netlify
Copy link

netlify bot commented Aug 12, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 70fd8c0
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/689b95cf36c4de00087f1c39

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 12, 2025

CodSpeed Performance Report

Merging #974 will not alter performance

Comparing ibraheemdev:ibraheem/id-hash (70fd8c0) with master (918d35d)

Summary

✅ 12 untouched benchmarks

@ibraheemdev ibraheemdev added this pull request to the merge queue Aug 13, 2025
Merged via the queue into salsa-rs:master with commit 5aab823 Aug 13, 2025
12 checks passed
@ibraheemdev ibraheemdev deleted the ibraheem/id-hash branch August 13, 2025 17:12
@github-actions github-actions bot mentioned this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants