refactor: Extract the cycle branches from fetch and maybe_changed_after
#955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
changed the title
fetch and maybe_changed_afterfetch and maybe_changed_after
MichaReiser
force-pushed
the
extract-cycle-branches
branch
from
b19ec4f to
d75390e
Compare
CodSpeed Performance ReportMerging #955 will not alter performanceComparing Summary
|
MichaReiser
force-pushed
the
extract-cycle-branches
branch
from
d75390e to
3bdf4ba
Compare
carljm
approved these changes
Aug 5, 2025
| } | ||
| } | ||
|
|
||
| QueryOriginRef::Assigned(_) => { |
Contributor
There was a problem hiding this comment.
This change is just to put the more frequent match arm first?
Contributor
Author
There was a problem hiding this comment.
Yeah. I find this also helps with readability because I can reason about the common case first
ibraheemdev
approved these changes
Aug 5, 2025
MichaReiser
force-pushed
the
extract-cycle-branches
branch
from
3bdf4ba to
8e0ee63
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and mark them as cold. I also reordered some other match statements so that the most likely branches come first.
This hopefully helps the compiler to generate more efficient code for the common case (no cycle)