Remove extra bounds checks from memo table hot-paths #938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small optimization that takes advantage of the fact that an index being valid for a
MemoTableguarantees that it is valid for the correspondingMemoTableTypes, so we can avoid the duplicate bounds checks here.It would be nice if we could remove the bounds and type checks here completely, but I don't think that's possible because we sometimes compute the
MemoIngredientIndexfrom a salsa supertypeId, which could be smuggled across databases.