-
Notifications
You must be signed in to change notification settings - Fork 192
Add option to track heap memory usage of memos #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MichaReiser
merged 1 commit into
salsa-rs:master
from
ibraheemdev:ibraheem/memory-usage-dump
Jun 25, 2025
Merged
Add option to track heap memory usage of memos #925
MichaReiser
merged 1 commit into
salsa-rs:master
from
ibraheemdev:ibraheem/memory-usage-dump
Jun 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #925 will not alter performanceComparing Summary
|
MichaReiser
reviewed
Jun 24, 2025
MichaReiser
approved these changes
Jun 24, 2025
Contributor
MichaReiser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this is great. I've only one recommendation on how we could possibly remove the get_size dependency entirely (in tests and in the generated macro)
b5dbb95 to
02b9ae4
Compare
MichaReiser
reviewed
Jun 25, 2025
e53c2ab to
18f5cc0
Compare
18f5cc0 to
5f33cd3
Compare
This was referenced Jun 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[salsa::tracked(heap_size)]will require the return type of a tracked function to implement theget_size2::GetSizetrait, and include the heap size in the new memory usage APIs. I'm not sureget-size2is the best crate to use, but it seems relatively comprehensive, and integrating it into ty was relatively simple with its derive macros. Note that it's not actually a dependency of salsa, it's just called by the generated proc-macro code.