Hide generated structs of tracked functions from docs via #[doc(hidden)]
#917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
regexident
force-pushed
the
doc-hidden-fn-structs
branch
from
54c5ebd to
d4d6fec
Compare
CodSpeed Performance ReportMerging #917 will not alter performanceComparing Summary
|
MichaReiser
approved these changes
Jun 17, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salsa also supports tracked methods and tracked associated methods, neither of which produce equivalent user-observable structs, so arguably neither should track functions, and the generated structs don't really provide a usable API anyway.