Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump parking_lot packages #303

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Bump parking_lot packages #303

merged 1 commit into from
Jul 6, 2022

Conversation

eliasmalik
Copy link
Contributor

This is motivated by recent changes to parking_lot affecting wasm32-unknown-unknown targets (see Amanieu/parking_lot#269 if interested). My project depends on parking_lot via salsa, which is why I'm facing this issue.

TLDR is that parking_lot released a new version that provides a fix for the above. I'm hoping that version can be included in a future version of salsa.

For reference, here's the relevant part of the changelog: https://github.com/Amanieu/parking_lot/blob/HEAD/CHANGELOG.md#parking_lot-0120-parking_lot_core-090-lock_api-046-2022-01-28

I belive the only changes that might affect APIs used by salsa are in PRs Amanieu/parking_lot#313 and https://github.com/Amanieu/parking_lot/pull/344/files, but I'm unfamiliar with the internals of either project so could easily be wrong.

I can build and test successfully locally with these bumps. Let me know if there's anything else I can do to help this over the line.

@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 81b7984
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/629f5293cafef800099c8f44

@jonas-schievink
Copy link
Contributor

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 6, 2022

Build succeeded:

@bors bors bot merged commit 754eea8 into salsa-rs:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants