Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by recent changes to
parking_lot
affectingwasm32-unknown-unknown
targets (see Amanieu/parking_lot#269 if interested). My project depends onparking_lot
viasalsa
, which is why I'm facing this issue.TLDR is that
parking_lot
released a new version that provides a fix for the above. I'm hoping that version can be included in a future version ofsalsa
.For reference, here's the relevant part of the changelog: https://github.com/Amanieu/parking_lot/blob/HEAD/CHANGELOG.md#parking_lot-0120-parking_lot_core-090-lock_api-046-2022-01-28
I belive the only changes that might affect APIs used by
salsa
are in PRs Amanieu/parking_lot#313 and https://github.com/Amanieu/parking_lot/pull/344/files, but I'm unfamiliar with the internals of either project so could easily be wrong.I can build and test successfully locally with these bumps. Let me know if there's anything else I can do to help this over the line.