Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Remove Namespaces From Reader #23

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

Sammyjo20
Copy link
Member

@Sammyjo20 Sammyjo20 commented Dec 4, 2023

This PR introduces the ability to remove namespaces from the XML reader in a memory-efficient way. The namespaces are not removed from the reader before reading, but the matcher changes if the user wants to discard namespaces. After that, the XML decoding passes in an XML configurator which removes the namespaces and element prefixes from the final searched XML.

I have also removed the namespaces from the XPath methods by using a different XPath configurator rule.

@Sammyjo20 Sammyjo20 changed the title Feature | Remove Namespaces From Reader" Feature | Remove Namespaces From Reader Dec 4, 2023
Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 marked this pull request as ready for review December 4, 2023 19:23
@Sammyjo20 Sammyjo20 requested a review from veewee December 4, 2023 19:23
Copy link
Collaborator

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Sammyjo20 Sammyjo20 merged commit c26b2f4 into v1 Dec 5, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants