Add xmlStandalone property to XmlWriter, includes a test and documentation #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sammyjo20
requested changes
Nov 8, 2023
src/XmlWriter.php
Outdated
| /** | ||
| * Set the XML standalone | ||
| */ | ||
| public function setXmlStandalone(bool $xmlStandalone): XmlWriter |
There was a problem hiding this comment.
Suggested change
| public function setXmlStandalone(bool $xmlStandalone): XmlWriter | |
| public function setXmlStandalone(bool $xmlStandalone): static |
There was a problem hiding this comment.
would you like setXmlEncoding and setXmlVersion also marked with static for the return type? They are currently XmlWriter
There was a problem hiding this comment.
Change made, also made the change for setXmlEncoding and setXmlVersion. It just makes sense to do :) Let me know if you think otherwise
|
Don't worry if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spatie's spatie/array-to-xml package exposes a parameter to set the XML standalone attribute in the declaration.
This pull request adds that to saloonphp/xml-wrangler. The implementation mirrors the existing API for XmlEncoding and XmlVersion.