Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAttributes and getContent documentation #14

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Conversation

bmckay959
Copy link
Contributor

@bmckay959 bmckay959 commented Nov 6, 2023

Not 100% sure how to best document this, but I wrestled with trying to grab the attributes for some time. Might be helpful for others.

Hoping to just start the conversation of documenting this.

Basically, the docs currently show how to 'query' these items, but not to actually retrieve these items.

Not 100% sure how to best document this, but I wrestled with trying to grab the attributes for some time. Might be helpful for others.

Hoping to just start the conversation of documenting this.
Copy link
Member

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @bmckay959 - I realise the docs could be improved in this regard. Once these suggestions have been changed I will merge it and improve the docs further.

.github/README.md Outdated Show resolved Hide resolved
.github/README.md Outdated Show resolved Hide resolved
bmckay959 and others added 2 commits November 6, 2023 11:16
Co-authored-by: Sam C <29132017+Sammyjo20@users.noreply.github.com>
Co-authored-by: Sam C <29132017+Sammyjo20@users.noreply.github.com>
Copy link
Member

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Sammyjo20 Sammyjo20 merged commit db57f4d into saloonphp:v1 Nov 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants