fix: W-17774391 - create table for data import tree JSON Error #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { key: 'fields', name: 'Fields' }, | ||
| ], | ||
| title: 'import Errors', | ||
| }); |
Member
There was a problem hiding this comment.
since we manually report the errors in the table we need to manually set the exit code to 1 here:
https://github.com/salesforcecli/plugin-deploy-retrieve/blob/a45867d06f7f511e973a955d4bab164d6486863d/src/commands/project/delete/source.ts#L306
cristiand391
approved these changes
Feb 21, 2025
Member
|
QA notes: ❌ JSON parse failure instead of error msg on non-sobject tree API error responses: NOTE: I put an invalid sobject in the plan file to get the err 🟢 table with record errors printed correctly 🟢 if error doesn't have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
create table for JSON error when using
data import tree.What issues does this PR fix or reference?
@W-17774391@