W-19995335: update validate agent #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
requested changes
Oct 23, 2025
| const targetOrg = flags['target-org']; | ||
| const conn = targetOrg.getConnection(flags['api-version']); | ||
| // Call Agent.compileAgent() API | ||
| await sleep(Duration.seconds(2)); |
Contributor
There was a problem hiding this comment.
let's remove this and the sleep
| }); | ||
| }); | ||
|
|
||
| describe('flag validation', () => { |
Contributor
There was a problem hiding this comment.
these tests should be removed, the --api-version flag validation is already tested in sf-plugins-core
| import { throwAgentCompilationError } from '../../../../src/common.js'; | ||
|
|
||
| describe('Agent Validate Authoring Bundle', () => { | ||
| describe('command configuration', () => { |
Contributor
There was a problem hiding this comment.
I don't think we need to test that the command has a specific summary, or required project, etc...
| } | ||
| } catch (error) { | ||
| // Handle validation errors | ||
| const err = SfError.wrap(error); |
Contributor
There was a problem hiding this comment.
shouldn't this be using the throwAgentCompilationError method?
Contributor
Author
There was a problem hiding this comment.
This catch block is used to handle all error, not only compilation errors returned from the api
WillieRuemmele
approved these changes
Oct 23, 2025
Contributor
QA Notes✅ : no error ➜ sf agent validate authoring-bundle
? API name of the authoring bundle to validate my_AGent
────── Validating my_AGent Authoring Bundle ──────
✔ Validating Authoring Bundle 1.36s
▸ Status: COMPLETED
▸ Errors: 0
Elapsed Time: 1.38s✅ : error ➜ sf agent validate authoring-bundle
? API name of the authoring bundle to validate my_AGent
────── Validating my_AGent Authoring Bundle ──────
✘ Validating Authoring Bundle 1.33s
▸ Status: ERROR
▸ Errors: 1
Elapsed Time: 1.34s
Compilation of the agent file failed with the following errors:
- SyntaxError: Unexpected 'sysem' [Ln 1, Col 0] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update error handling for compilation errors.
What issues does this PR fix or reference?
@W-19995335@