feat: disable nut double-quote rule

salesforcecli · Mar 15, 2023 · 0dea4d3 · 0dea4d3
1 parent 7e584c9
commit 0dea4d3
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -68,15 +68,18 @@ module.exports = {
 | [id-flag-suggestions](docs/rules/id-flag-suggestions.md)                               | Create better salesforceId flags with length and startsWith properties                                  |         | ✈️ ✅ | 🔧 | 💡 |
 | [no-args-parse-without-strict-false](docs/rules/no-args-parse-without-strict-false.md) | If you parse args/argv, the class should have strict set to false                                       | ✈️ ✅    |      | 🔧 |    |
 | [no-builtin-flags](docs/rules/no-builtin-flags.md)                                     | Handling for sfdxCommand's flags.builtin                                                                | ✈️      |      | 🔧 |    |
+| [no-classes-in-command-return-type](docs/rules/no-classes-in-command-return-type.md)   | The return type of the run method should not contain a class.                                           | ✈️ ✅    |      | 🔧 |    |
 | [no-deprecated-properties](docs/rules/no-deprecated-properties.md)                     | Removes non-existent properties left over from SfdxCommand                                              | ✈️      |      | 🔧 |    |
 | [no-duplicate-short-characters](docs/rules/no-duplicate-short-characters.md)           | Prevent duplicate use of short characters or conflicts between aliases and flags                        | ✈️ ✅    |      |    |    |
+| [no-execcmd-double-quotes](docs/rules/no-execcmd-double-quotes.md)                     | Do not use double quotes in NUT examples.  They will not work on windows                                | 📚 ✈️ ✅ |      | 🔧 |    |
 | [no-filepath-flags](docs/rules/no-filepath-flags.md)                                   | Change filepath flag to file flag                                                                       |         |      | 🔧 |    |
 | [no-h-short-char](docs/rules/no-h-short-char.md)                                       | Do not allow creation of a flag with short char -h                                                      | ✈️ ✅    |      |    |    |
 | [no-hardcoded-messages-commands](docs/rules/no-hardcoded-messages-commands.md)         | Use loaded messages and separate files for messages                                                     |         | ✈️ ✅ |    |    |
 | [no-hardcoded-messages-flags](docs/rules/no-hardcoded-messages-flags.md)               | Use loaded messages and separate files for messages                                                     |         | ✈️ ✅ |    |    |
 | [no-hyphens-aliases](docs/rules/no-hyphens-aliases.md)                                 | Mark when an alias starts with a hyphen, like -f or --foo                                               | ✈️ ✅    |      | 🔧 |    |
 | [no-id-flags](docs/rules/no-id-flags.md)                                               | Change Id flag to salesforceId                                                                          | ✈️      |      | 🔧 |    |
 | [no-json-flag](docs/rules/no-json-flag.md)                                             | Do not allow creation of json flag                                                                      | ✈️ ✅    |      |    |    |
+| [no-messages-load](docs/rules/no-messages-load.md)                                     | Use Messages.loadMessages() instead of Messages.load()                                                  | 📚 ✈️ ✅ |      | 🔧 |    |
 | [no-missing-messages](docs/rules/no-missing-messages.md)                               | Checks core Messages usage for correct usage of named messages and message tokens                       | 📚 ✈️ ✅ |      |    |    |
 | [no-number-flags](docs/rules/no-number-flags.md)                                       | Change number flag to integer                                                                           |         |      | 🔧 |    |
 | [no-oclif-flags-command-import](docs/rules/no-oclif-flags-command-import.md)           | Change import of flags and Command from oclif to use sf-plugins-core                                    | ✈️ ✅    |      | 🔧 |    |

diff --git a/docs/rules/no-classes-in-command-return-type.md b/docs/rules/no-classes-in-command-return-type.md
@@ -0,0 +1,7 @@
+# The return type of the run method should not contain a class (`sf-plugin/no-classes-in-command-return-type`)
+
+💼 This rule is enabled in the following configs: ✈️ `migration`, ✅ `recommended`.
+
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
+<!-- end auto-generated rule header -->
diff --git a/docs/rules/no-execcmd-double-quotes.md b/docs/rules/no-execcmd-double-quotes.md
@@ -0,0 +1,7 @@
+# Do not use double quotes in NUT examples.  They will not work on windows (`sf-plugin/no-execcmd-double-quotes`)
+
+💼 This rule is enabled in the following configs: 📚 `library`, ✈️ `migration`, ✅ `recommended`.
+
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
+<!-- end auto-generated rule header -->
diff --git a/docs/rules/no-messages-load.md b/docs/rules/no-messages-load.md
@@ -0,0 +1,7 @@
+# Use Messages.loadMessages() instead of Messages.load() (`sf-plugin/no-messages-load`)
+
+💼 This rule is enabled in the following configs: 📚 `library`, ✈️ `migration`, ✅ `recommended`.
+
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
+<!-- end auto-generated rule header -->
diff --git a/src/index.ts b/src/index.ts
@@ -51,7 +51,7 @@ const library = {
   rules: {
     'sf-plugin/no-missing-messages': 'error',
     'sf-plugin/no-messages-load': 'error',
-    'sf-plugin/no-execcmd-double-quotes': 'error',
+    'sf-plugin/no-execcmd-double-quotes': 'off',
   },
 };