-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readme to include bun install #505
base: master
Are you sure you want to change the base?
Conversation
Thanks for the contribution! Before we can merge this, we need @Electroid to sign the Salesforce Inc. Contributor License Agreement. |
![]() |
Closing and reopening to trigger the |
@Electroid thanks for this suggestion! However, bun is not currently a runtime that we support, and we don't want to give a false impression by including it in the readme. That being said, we are open to supporting bun, but we'd need a guarantee that the package works in that environment. We'd be happy accept a contribution that runs our unit tests in bun to provide that guarantee. |
Hi @wjhsf, totally understand. I did try using Bun with your package and it does work! Snippet using
|
I'd imagine that it doesn't make much of a difference, but just as a footnote we'll be switching to vitest soon. I'm working on a PR for after we switch to ESM (#506, which also removes the CJS-only vows tests). |
Updates the readme to add bun install instructions alongside npm and yarn.