Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to punycode 2.1 #121

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Upgrade to punycode 2.1 #121

merged 1 commit into from
Aug 14, 2018

Conversation

stash
Copy link
Collaborator

@stash stash commented Jul 30, 2018

Fixes #82

@stash stash self-assigned this Jul 30, 2018
@stash
Copy link
Collaborator Author

stash commented Jul 30, 2018

TravisCI test indicates that this seems to work with node >= 0.10.

@stash stash requested a review from awaterma July 30, 2018 21:41
awaterma
awaterma approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the latest release. I don't see any issues in the dependency, according to NPM. Looks like our checks are passing as well. Per discussion I think we can merge this.

@awaterma awaterma merged commit 8302ebc into master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaterma awaterma awaterma approved these changes

Assignees

@stash stash

Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stash @awaterma