Use os-maven-plugin's name + arch directly instead of classifier #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that classifierWithLikes can be used elsewhere
|
Thanks for the contribution! Before we can merge this, we need @skjolber to sign the Salesforce.com Contributor License Agreement. |
|
@nikolay-pshenichny this salesforce-cla just gives an error |
|
Bouncing PR to retry CLA bot |
|
@rmichela Getting the message: You already signed the CLA on 2022-11-23. So good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use os-maven-plugin's
classifierWithLikes, however doing so causes this plugin to look for linux-flavoured binary which does not exist in this project (nor does it need to).According to the docs the
classifieris just short forname-arch, so this change should preserve the current functionality while allowing for more flexiblity whenever linux flavours executables are necessary.