Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of protolock for ARM64 platform #21

Closed
wants to merge 2 commits into from

Conversation

liusheng
Copy link
Contributor

When try to build other projects depend on protolock on ARM64 server, it will raise error:

OS not supported. Unable to find a protolock binary for the classifier linux-aarch_64

This change add a protolock binary for ARM64/aarch64 platform.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @liusheng to sign the Salesforce.com Contributor License Agreement.

@liusheng
Copy link
Contributor Author

Hi @rmichela ,
Could you please help to take a look this PR ? Thank you.

Copy link
Collaborator

@rmichela rmichela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get the binary for arm64? There is no official protolock binary for that platform.

https://github.com/nilslice/protolock/releases/tag/v0.15.0

@liusheng
Copy link
Contributor Author

liusheng commented Jan 26, 2021

Where did you get the binary for arm64? There is no official protolock binary for that platform.

https://github.com/nilslice/protolock/releases/tag/v0.15.0

Sorry, I compiled the protolock binary on my ARM64 server, maybe need to firstly promote ARM64 release in protolock upstream ?

@rmichela
Copy link
Collaborator

maybe need to firstly promote ARM64 release in protolock upstream

Yes. That's a good idea. 😄 While I like the idea of this PR, I can't accept an opaque binary that could do literally anything. Thank you for being understanding.

@liusheng
Copy link
Contributor Author

Hi @rmichela , Thanks for your reply and suggestion, I have promoted protolock upstream to published a new 1.15.1 version including ARM64 binary, see: https://github.com/nilslice/protolock/releases/tag/v0.15.1
I will update this PR replace with the new arm64 binary, please take a look again.
Thank you.

@rmichela
Copy link
Collaborator

Perfect! Thank you.

@liusheng
Copy link
Contributor Author

Hi @rmichela
I have submitted the new protolock in #22
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants