chore(ci): run perf testing on release branches @W-18882666 #5408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
commented
Jul 7, 2025
the test branch name doesn't match the expected regex pattern
tach is grumpy and wants to be updated
If you're reading this commit message, congrats! You win a prize!
I think GitHub Actions might not like it.
wjhsf
changed the title
|
@wjhsf will this run block release PRs until it finishes (3-4 hour delay), or is it mainly for running in the background? |
|
This runs on push to a release branch, i.e. after a PR merge. I don't know whether Nucleus does the npm release before or after it does the PR merge, so it may or may not be blocking? |
rax-it
reviewed
Jul 11, 2025
| @@ -0,0 +1,59 @@ | |||
| name: Run Performance Benchmarks | |||
There was a problem hiding this comment.
@wjhsf Mostly a curiosity question, did we test the workflow ? If so, how?
There was a problem hiding this comment.
To validate that the workflow runs as expected, I initially configured it to run on this branch. You can see the result of a successful run here. The run took 3h 49m, so we're well within the 6 hour execution time limit. The PR branch logic has been removed from the final PR submission.
rax-it
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Running performance tests takes a long time (~6 hours on my slow old laptop, ~3 hours on my shiny new one). It's too long to be convenient to run locally, and finding the time / remembering to get it set up is easy to forget. Hence, CI! However, most changes don't have a significant impact on performance; the changes add up over time. We mostly care about the performance of the versions that ship in Salesforce releases. This PR sets up CI that runs on changes to release branches, so that we can see how each release compares to the prior one.
To validate that the workflow runs as expected, I initially configured it to run on this branch. You can see the result of a successful run here. The run took 3h 49m, so we're well within the 6 hour execution time limit. The PR branch logic has been removed from the final PR submission.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item