Skip to content

@W-17769475 chore: release v8.13.1 #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2025
Merged

@W-17769475 chore: release v8.13.1 #5201

merged 6 commits into from
Feb 7, 2025

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Feb 6, 2025

Details

Does this pull request introduce a breaking change?

  • ๐Ÿ˜ฎโ€๐Ÿ’จ No, it does not introduce a breaking change.
  • ๐Ÿ’” Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • ๐Ÿคž No, it does not introduce an observable change.
  • ๐Ÿ”ฌ Yes, it does include an observable change.

GUS work item

wjhsf and others added 5 commits February 5, 2025 12:49
โ€ฆh SSR-internal variables (#5196)

* fix(ssr): prohibit variable names in customer code from colliding with SSR-internal variables

* chore: make generateMarkup inaccessible as a variable
* feat(rollup-plugin): expose version

* test(rollup-plugin): exposes plugin version

* chore: add comment

---------

Co-authored-by: Dale Bustad <dale@divmain.com>
* revert: temporarily undo Locker-specific logic

* chore: revert test
@wjhsf wjhsf requested a review from a team as a code owner February 6, 2025 22:11
jye-sf
jye-sf previously approved these changes Feb 6, 2025
@wjhsf
Copy link
Contributor Author

wjhsf commented Feb 6, 2025

/nucleus release

Copy link
Contributor

โŒ One or More Pre-release Checks Failed

  • โœ… Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy

  • โœ… Check PR is approved
    PR 5201 is approved

  • โœ… Check PR is mergeable
    PR 5201 is mergeable

  • โœ… Check GUS reference is present
    GUS Work Item @W-17769475 parsed from PR title

  • โŒ Check no conflicting Github release
    A Github release already exists with a tag of v8.13.0. Please commit/push a version bump to the wjh/publish-v8.13.1 branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • โŒ Check NPM packages have not been released yet
    Version 8.13.0 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • โšช๏ธ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • โšช๏ธ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@wjhsf
Copy link
Contributor Author

wjhsf commented Feb 6, 2025

/nucleus release

Copy link
Contributor

Stage test must complete successfully before release can be run.

@wjhsf
Copy link
Contributor Author

wjhsf commented Feb 6, 2025

/nucleus release

Copy link
Contributor

โŒ One or More Pre-release Checks Failed

  • โœ… Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy
  • โŒ Check PR is approved
    PR 5201 must be approved by at least one approver
  • โœ… Check PR is mergeable
    PR 5201 is mergeable
  • โœ… Check GUS reference is present
    GUS Work Item @W-17769475 parsed from PR title
  • โœ… Check no conflicting Github release
  • โœ… Check NPM packages have not been released yet
  • โšช๏ธ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • โšช๏ธ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@wjhsf wjhsf requested a review from jye-sf February 6, 2025 23:35
Copy link
Contributor

โœ… All Pre-release Checks Passed

  • โœ… Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy
  • โœ… Check PR is approved
    PR 5201 is approved
  • โœ… Check PR is mergeable
    PR 5201 is mergeable
  • โœ… Check GUS reference is present
    GUS Work Item @W-17769475 parsed from PR title
  • โœ… Check no conflicting Github release
  • โœ… Check NPM packages have not been released yet
  • โšช๏ธ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • โšช๏ธ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

Copy link
Contributor

๐Ÿšข Release Starting

This pull request has been merged and the release of version 8.13.1 is starting.

You can monitor the progress of the release in Nucleus by visiting the following URL.
https://nucleus.uipengsys-public.buildndeliver-s.aws-esvc1-useast2.aws.sfdc.cl/workflows/260379

@wjhsf wjhsf merged commit 76b9d1d into release Feb 7, 2025
21 of 22 checks passed
@wjhsf wjhsf deleted the wjh/publish-v8.13.1 branch February 7, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants