Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release v8.5.0 #4738

Merged
merged 12 commits into from
Oct 30, 2024
Merged

chore: release v8.5.0 #4738

merged 12 commits into from
Oct 30, 2024

Conversation

nolanlawson
Copy link
Collaborator

Details

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

wjhsf and others added 12 commits October 29, 2024 10:52
@wjhsf @ekashida @nolanlawson
feat(ssr): reflect global HTML attributes @W-16871464 (#4707)
50df802 
* chore: remove compile time handling of aria attribute reflection

* chore: update public attribute accessors

* chore: reflect attrs to props

* chore: reflect prop to attr

* chore: update back reference

* test: reflection

* chore: tweaks

* chore: review feedback

* chore: types

* test: refactor

* chore: normalize all attribute methods

* chore: move attr-to-prop helpers to @lwc/shared

* chore: use null prototype

* chore: rename variable

* fix: add missing comma

* chore: dedupe mappings

* feat(ssr): reflect global HTML attributes

* feat(ssr): reflect global HTML attributes, but better

* chore(ssr): mostly revert move to @lwc/shared

* feat(ssr): reflect global HTML attributes, but better

* Update packages/@lwc/ssr-runtime/src/reflection.ts

Co-authored-by: Eugene Kashida <ekashida@gmail.com>

* fix(ssr): hidden is a "true" boolean attribute

* fix(template-compiler): use `Array.from` instead of `Object.entries`

* Update packages/@lwc/ssr-runtime/src/reflection.ts

* Update packages/@lwc/ssr-runtime/src/reflection.ts

* Update packages/@lwc/ssr-runtime/src/reflection.ts

* fix(ssr): handle infinite tabindex

* chore(template-compiler): remove duplicate export

---------

Co-authored-by: Eugene Kashida <ekashida@gmail.com>
Co-authored-by: Nolan Lawson <nlawson@salesforce.com>
@nolanlawson @wjhsf
feat(ssr): implement static stylesheets (#4715)
e0d435e 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@cardoso @nolanlawson
chore(tests): use built-in snapshot matcher for fixtures (#4710)
a8ea869 
Co-authored-by: Nolan Lawson <nlawson@salesforce.com>
@nolanlawson
chore(ci): bump node/chrome/gha versions (#4722)
577d95f
@nolanlawson
test(ssr): add more tests for scoped slots (#4725)
0e0a6d0
@wjhsf
refactor(ssr): use import helpers (#4724)
aa49145
@dependabot @nolanlawson
build(deps): bump the theoretically-non-breaking group across 1 direc…
0b4d5ac 
…tory with 31 updates (#4723)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nolan Lawson <nlawson@salesforce.com>
@nolanlawson
test(ssr): add tests for adjacent text nodes (#4729)
59251bf
@nolanlawson @wjhsf
feat: allow passing default export to renderComponent (#4727)
641b740 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@nolanlawson @wjhsf
test(ssr): add tests for type coercion in rendering (#4730)
211897e 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@nolanlawson @wjhsf
chore(ci): update chrome (#4728)
e3f50fc 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@nolanlawson
chore: release v8.5.0 (#4736)
0343d05
@nolanlawson nolanlawson requested a review from a team as a code owner October 30, 2024 22:31
@nolanlawson
Copy link
Collaborator Author

/nucleus release

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • ✅ Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy
  • ❌ Check PR is approved
    PR 4738 must be approved by at least one approver
  • ✅ Check PR is mergeable
    PR 4738 is mergeable
  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR
  • ✅ Check no conflicting Github release
  • ✅ Check NPM packages have not been released yet
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@nolanlawson
Copy link
Collaborator Author

/nucleus release --force

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

✅ All Pre-release Checks Passed

  • ⚪️ Check PR user has rights to execute the workflow (skipped)
    Skipping PR owner check since release is forced.
  • ⚪️ Check PR is approved (skipped)
    Skipping PR approved check since release is forced.
  • ✅ Check PR is mergeable
    PR 4738 is mergeable
  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR
  • ⚪️ Check no conflicting Github release (skipped)
    Skipping Github release check since release is forced.
  • ⚪️ Check NPM packages have not been released yet (skipped)
    Skipping check since release is forced.
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since release is forced.
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

Error occurred when performing PR merge: At least 1 approving review is required by reviewers with write access.

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

❌ An unexpected error occurred while attempting to start the release stage of workflow 251778. Please try to start the stage again, or reach out to #nucleus-talk for help.

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

✅ All Pre-release Checks Passed

  • ✅ Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy
  • ✅ Check PR is approved
    PR 4738 is approved
  • ✅ Check PR is mergeable
    PR 4738 is mergeable
  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR
  • ✅ Check no conflicting Github release
  • ✅ Check NPM packages have not been released yet
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

🚢 Release Starting

This pull request has been merged and the release of version 8.5.0 is starting.

You can monitor the progress of the release in Nucleus by visiting the following URL.
https://nucleus.uipengsys-public.buildndeliver-s.aws-esvc1-useast2.aws.sfdc.cl/workflows/251778

@nolanlawson nolanlawson merged commit 0343d05 into release Oct 30, 2024
21 checks passed
@nolanlawson nolanlawson deleted the nolan/release-20241030-2 branch October 30, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jye-sf jye-sf jye-sf approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nolanlawson @jye-sf @wjhsf @cardoso