Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(engine-server): run test fixtures concurrently #4690

Merged

Conversation

cardoso
Copy link
Contributor

@cardoso cardoso commented Oct 24, 2024

Details

Small but easy improvement observed locally ~1.65s to ~1.25s.

This is still the longest-running test file (in subsequent runs), so this might help uncover other ways to improve.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

GUS work item

Copy link
Contributor

@wjhsf wjhsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool! Is there any perf gain if we do this for fixtures in other packages as well?

@cardoso
Copy link
Contributor Author

cardoso commented Oct 24, 2024

@wjhsf yes, I have another PR coming up which refactors the test-fixture-dir.ts file and removes the custom toMatchFile sync matcher in favor of vitest's async toMatchFileSnapshot. I saw bigger improvements (~1s for this test), but wanted to push this simple one first to see the difference. It also improves the UX when using vitest through VSCode:

Screenshot 2024-10-24 at 11 31 01

With the custom matcher it won't show the diff and file locations as nicely:

Screenshot 2024-10-24 at 11 33 07

@nolanlawson
Copy link
Collaborator

/nucleus test

Copy link
Collaborator

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nolanlawson nolanlawson merged commit 3ee2b6d into salesforce:master Oct 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants