Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ssr-compiler): track mutated attributes #4616

Merged
merged 2 commits into from
Oct 7, 2024
Merged

feat(ssr-compiler): track mutated attributes #4616

merged 2 commits into from
Oct 7, 2024

Conversation

ekashida
Copy link
Member

@ekashida ekashida commented Oct 7, 2024

Details

Track mutated attributes and render results on the host element.

GUS work item

W-16871307

@ekashida ekashida requested a review from a team as a code owner October 7, 2024 19:21
@ekashida ekashida enabled auto-merge (squash) October 7, 2024 19:36
@ekashida ekashida merged commit 5500b2f into master Oct 7, 2024
11 checks passed
@ekashida ekashida deleted the ekashida/mutated-attributes branch October 7, 2024 20:04
@nolanlawson
Copy link
Collaborator

@ekashida This implementation is not completely correct. Mutation tracking is supposed to only occur during connectedCallback() – no other callbacks (e.g. render()).

I believe this will fail once we start running the hydration tests for @lwc/ssr-compiler though so we can handle it then.

@nolanlawson
Copy link
Collaborator

Wrote a new test: #4634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhsf wjhsf wjhsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekashida @nolanlawson @wjhsf