perf: Apply static parts optimization to dynamic style #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntent-optimization-style
jmsjtu
commented
Mar 20, 2024
Comment on lines
151
to
+152
| ); | ||
| if (data.style && !isString(data.style)) { | ||
| logError( | ||
| `Invalid 'style' attribute passed to <${sel}> is ignored. This attribute must be a string value.`, | ||
| vmBeingRendered | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
I ended up moving this check into the patchStyleAttribute routine instead because there isn't a straight-forward way to retrieve the tag name inside the st function.
I've added a test to ensure it provides the same results.
wjhsf
reviewed
Mar 20, 2024
packages/@lwc/engine-core/src/framework/modules/computed-style-attr.ts
Outdated
Show resolved
Hide resolved
nolanlawson
approved these changes
Mar 20, 2024
packages/@lwc/integration-karma/test/template/attribute-style/invalid/index.spec.js
Outdated
Show resolved
Hide resolved
nolanlawson
reviewed
Mar 20, 2024
…-attr.ts Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR expands the static content optimization to include dynamic styles as part of #3624.
The PR is broken into parts to more easily review:
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
Select Row Checkbox
W-14560941