Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine-dom): make feature flags work #2812

Merged
merged 11 commits into from
May 16, 2022
Merged

fix(engine-dom): make feature flags work #2812

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3799eb9
fix(engine-dom): make feature flags work
nolanlawson Apr 29, 2022
9f6afe1
fix: license headers
nolanlawson Apr 29, 2022
43efa19
test: fix jest tests
nolanlawson Apr 29, 2022
e2b74c9
test: fix test
nolanlawson Apr 29, 2022
76c66b6
test: fix test
nolanlawson Apr 29, 2022
72afdc0
fix: use Eugene's technique instead
nolanlawson Apr 29, 2022
79a41c8
Revert "fix: use Eugene's technique instead"
nolanlawson Apr 29, 2022
8c08a6e
fix: use Eugene's technique instead
nolanlawson Apr 29, 2022
01c9664
fix: revert unnecessary test change
nolanlawson Apr 29, 2022
a18f086
fix: revert, use the elaborate test instead
nolanlawson May 2, 2022
61f1eb7
fix: fix feature flags in engine-server as well
nolanlawson May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: revert unnecessary test change
  • Loading branch information
@nolanlawson
nolanlawson committed Apr 29, 2022
commit 01c9664d8b3d33e232d85553a49f0ef5a931f29c
1 change: 0 additions & 1 deletion packages/integration-karma/scripts/karma-plugins/env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ function createEnvFile() {
MIXED_SHADOW: ${FORCE_NATIVE_SHADOW_MODE_FOR_TEST},
NATIVE_SHADOW: ${!SYNTHETIC_SHADOW_ENABLED || FORCE_NATIVE_SHADOW_MODE_FOR_TEST},
NATIVE_SHADOW_ROOT_DEFINED: typeof ShadowRoot !== 'undefined',
SYNTHETIC_SHADOW_ENABLED: ${SYNTHETIC_SHADOW_ENABLED},
LWC_VERSION: ${JSON.stringify(LWC_VERSION)}
}
};
Expand Down