-
Couldn't load subscription status.
- Fork 423
feat: add HMR functionality #2071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚠ Performance RegressionBest has detected that there is a Please click here to see more details. Click to view significantly changed benchmarks@lwc/engine-dom
@lwc/engine-server
|
|
| Job | Project | Branch | Steps | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ✅ create-canary-release | salesforce/lwc | master |
|
||||||||||||
| ❌ build-dependency step node-install failed: Command yarn install failed |
lwc/lwc-platform | master |
|
||||||||||||
| ❌ build-dependency step node-install failed: Command yarn install failed |
salesforce/lightning-components | master |
|
||||||||||||
| ✅ build-dependency | nucleus-templates/lwc-components | master |
|
||||||||||||
| ❌ build-dependency step node-install failed: Command yarn install failed |
BuilderFramework/builder-framework | master |
|
||||||||||||
| ✅ build-dependency | salesforce/lwr | master |
|
||||||||||||
| ❌ build-dependency step node-install failed: Command yarn install failed |
communities/webruntime | master |
|
||||||||||||
| ❌ build-dependency step node-install failed: Command yarn install failed |
BuilderFramework/canonical-ui-metadata-vscode-extension | master |
|
||||||||||||
| ✅ build-dependency | uiplatform/nucleus | master |
|
||||||||||||
| ❌ build-dependency step node-install failed: Command yarn install failed |
salesforce/lds | master |
|
||||||||||||
| ✅ build-dependency | salesforce/lds-lightning-platform | master |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests are failing, and perf numbers are not good, not sure if it is really related to this.
⚠ Performance RegressionBest has detected that there is a Please click here to see more details. Click to view significantly changed benchmarks@lwc/engine-dom
@lwc/engine-server
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Details
Add APIs to allow Hot Module Reload
(this is a rebase from Caridy's old PR)