Skip to content

Conversation

@diervo
Copy link
Contributor

@diervo diervo commented Oct 30, 2020

Details

Add APIs to allow Hot Module Reload
(this is a rebase from Caridy's old PR)

@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 9.7% performance regression across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

@lwc/engine-dom

❌ Regressions base (2342e57) target (7fdb0d4) trend
ss-slot-create-container.benchmark/benchmark-slot-ss/synthetic-shadow-create 233.97 (± 1.89ms) 266.80 (± 1.96ms) +32.8ms (14.0%)
ss-slot-update-component-with-slot.benchmark/benchmark-slot-ss/synthetic-shadow-slot-update-component-with-slot 24.27 (± 0.79ms) 26.89 (± 0.94ms) +2.6ms (10.8%)
ss-slot-update-container-template.benchmark/benchmark-slot-ss/synthetic-shadow-slot-update-container-template 23.39 (± 1.18ms) 26.34 (± 0.46ms) +2.9ms (12.6%)
ss-slot-update-slotted-content.benchmark/benchmark-slot-ss/synthetic-shadow-slot-update-slotted-content 180.10 (± 6.08ms) 189.19 (± 7.95ms) +9.1ms (5.0%)
table-append-1k.benchmark/benchmark-table/append/1k 242.73 (± 1.71ms) 278.87 (± 1.94ms) +36.1ms (14.9%)
table-clear-1k.benchmark/benchmark-table/clear/1k 13.64 (± 0.16ms) 16.90 (± 0.18ms) +3.3ms (23.9%)
table-create-10k.benchmark/benchmark-table/create/10k 1276.40 (± 16.50ms) 1463.79 (± 9.45ms) +187.4ms (14.7%)
table-create-1k.benchmark/benchmark-table/create/1k 146.76 (± 1.58ms) 173.68 (± 1.29ms) +26.9ms (18.3%)
table-update-10th-1k.benchmark/benchmark-table/update-10th/1k 134.40 (± 1.66ms) 147.99 (± 1.33ms) +13.6ms (10.1%)
tablecmp-append-1k.benchmark/benchmark-table-component/append/1k 353.80 (± 1.72ms) 386.05 (± 3.34ms) +32.3ms (9.1%)
tablecmp-clear-1k.benchmark/benchmark-table-component/clear/1k 6.58 (± 0.12ms) 9.89 (± 0.16ms) +3.3ms (50.4%)
tablecmp-create-10k.benchmark/benchmark-table-component/create/10k 1951.33 (± 10.03ms) 2154.75 (± 12.86ms) +203.4ms (10.4%)
tablecmp-create-1k.benchmark/benchmark-table-component/create/1k 223.01 (± 1.48ms) 253.59 (± 1.40ms) +30.6ms (13.7%)
tablecmp-update-10th-1k.benchmark/benchmark-table-component/update-10th/1k 113.23 (± 1.10ms) 131.25 (± 0.69ms) +18.0ms (15.9%)
wc-append-1k.benchmark/benchmark-table-wc/append/1k 481.15 (± 3.82ms) 511.87 (± 10.76ms) +30.7ms (6.4%)
wc-clear-1k.benchmark/benchmark-table-wc/clear/1k 21.45 (± 0.22ms) 26.77 (± 0.30ms) +5.3ms (24.8%)
wc-create-10k.benchmark/benchmark-table-wc/create/10k 2941.10 (± 24.02ms) 3242.93 (± 20.38ms) +301.8ms (10.3%)
wc-create-1k.benchmark/benchmark-table-wc/create/1k 331.37 (± 0.87ms) 369.39 (± 1.63ms) +38.0ms (11.5%)
wc-update-10th-1k.benchmark/benchmark-table-wc/update-10th/1k 113.83 (± 0.61ms) 131.29 (± 1.30ms) +17.5ms (15.3%)

@lwc/engine-server

✅ Improvements base (2342e57) target (7fdb0d4) trend
table-render-10k.benchmark/benchmark-table/render/10k 504.55 (± 18.37ms) 467.23 (± 12.69ms) -37.3ms (7.4%)
tablecmp-render-10k.benchmark/benchmark-table-component/render/10k 1139.41 (± 24.09ms) 1082.13 (± 29.66ms) -57.3ms (5.0%)

@salesforce-nucleus
Copy link
Contributor

⚠️ Downstream dependency checks are failing

One or more downstream dependency checks failed against this PR.

Click to expand
Job Project Branch Steps
✅ create-canary-release salesforce/lwc master
✅ git clone 3s
✅ load project config <1s
✅ install dependencies 7m 41s
✅ build project 1m 8s
✅ upload repo snapshot 40s
✅ publish canary release 1m 4s
❌ build-dependency
step node-install failed: Command yarn install failed
lwc/lwc-platform master
✅ git clone 10s
✅ load project config <1s
✅ patch npm dependency versions <1s
❌ install dependencies 13m 57s
🔵 build project
🔵 run unit test
❌ build-dependency
step node-install failed: Command yarn install failed
salesforce/lightning-components master
✅ git clone 26s
🌀 load project config
✅ patch npm dependency versions <1s
❌ install dependencies 5s
🔵 build project
🔵 run unit test
✅ build-dependency nucleus-templates/lwc-components master
✅ git clone 7s
✅ load project config <1s
✅ patch npm dependency versions <1s
✅ install dependencies 43m 8s
✅ build project <1s
✅ run unit test 5s
❌ build-dependency
step node-install failed: Command yarn install failed
BuilderFramework/builder-framework master
✅ git clone 14s
✅ load project config <1s
✅ patch npm dependency versions <1s
❌ install dependencies 21m 17s
🔵 build project
🔵 run unit test
✅ build-dependency salesforce/lwr master
✅ git clone 23s
✅ load project config <1s
✅ patch npm dependency versions <1s
✅ install dependencies 21m 34s
✅ build project 1m 28s
✅ run unit test 2m 12s
❌ build-dependency
step node-install failed: Command yarn install failed
communities/webruntime master
✅ git clone 1m 28s
🌀 load project config
✅ patch npm dependency versions <1s
❌ install dependencies 2s
🔵 build project
🔵 run unit test
❌ build-dependency
step node-install failed: Command yarn install failed
BuilderFramework/canonical-ui-metadata-vscode-extension master
✅ git clone 39s
✅ load project config <1s
✅ patch npm dependency versions <1s
❌ install dependencies 16m 48s
🔵 build project
🔵 run unit test
✅ build-dependency uiplatform/nucleus master
✅ git clone 21s
✅ load project config <1s
✅ patch npm dependency versions <1s
✅ install dependencies 23m 3s
✅ build project 2m 45s
✅ run unit test <1s
❌ build-dependency
step node-install failed: Command yarn install failed
salesforce/lds master
✅ git clone 15s
✅ load project config <1s
✅ patch npm dependency versions <1s
❌ install dependencies 17m 54s
🔵 build project
🔵 run unit test
✅ build-dependency salesforce/lds-lightning-platform master
✅ git clone 42s
✅ load project config <1s
✅ patch npm dependency versions <1s
✅ install dependencies 37m 21s
✅ build project 5m 35s
✅ run unit test 1m 58s

View full details and logs

Copy link
Collaborator

@caridy caridy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are failing, and perf numbers are not good, not sure if it is really related to this.

@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 9.7% performance regression across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

@lwc/engine-dom

❌ Regressions base (2342e57) target (cc82c57) trend
ss-slot-create-container.benchmark/benchmark-slot-ss/synthetic-shadow-create 233.97 (± 1.89ms) 266.88 (± 1.64ms) +32.9ms (14.1%)
ss-slot-update-component-with-slot.benchmark/benchmark-slot-ss/synthetic-shadow-slot-update-component-with-slot 24.27 (± 0.79ms) 27.86 (± 1.49ms) +3.6ms (14.8%)
ss-slot-update-container-template.benchmark/benchmark-slot-ss/synthetic-shadow-slot-update-container-template 23.39 (± 1.18ms) 26.93 (± 0.93ms) +3.5ms (15.2%)
ss-slot-update-slotted-content.benchmark/benchmark-slot-ss/synthetic-shadow-slot-update-slotted-content 180.10 (± 6.08ms) 192.98 (± 6.74ms) +12.9ms (7.1%)
table-append-1k.benchmark/benchmark-table/append/1k 242.73 (± 1.71ms) 278.23 (± 1.19ms) +35.5ms (14.6%)
table-clear-1k.benchmark/benchmark-table/clear/1k 13.64 (± 0.16ms) 16.85 (± 0.19ms) +3.2ms (23.5%)
table-create-10k.benchmark/benchmark-table/create/10k 1276.40 (± 16.50ms) 1448.86 (± 10.57ms) +172.5ms (13.5%)
table-create-1k.benchmark/benchmark-table/create/1k 146.76 (± 1.58ms) 174.85 (± 0.82ms) +28.1ms (19.1%)
table-update-10th-1k.benchmark/benchmark-table/update-10th/1k 134.40 (± 1.66ms) 147.82 (± 2.01ms) +13.4ms (10.0%)
tablecmp-append-1k.benchmark/benchmark-table-component/append/1k 353.80 (± 1.72ms) 387.77 (± 2.41ms) +34.0ms (9.6%)
tablecmp-clear-1k.benchmark/benchmark-table-component/clear/1k 6.58 (± 0.12ms) 9.84 (± 0.16ms) +3.3ms (49.7%)
tablecmp-create-10k.benchmark/benchmark-table-component/create/10k 1951.33 (± 10.03ms) 2133.43 (± 13.02ms) +182.1ms (9.3%)
tablecmp-create-1k.benchmark/benchmark-table-component/create/1k 223.01 (± 1.48ms) 253.25 (± 1.50ms) +30.2ms (13.6%)
tablecmp-update-10th-1k.benchmark/benchmark-table-component/update-10th/1k 113.23 (± 1.10ms) 129.64 (± 1.28ms) +16.4ms (14.5%)
wc-append-1k.benchmark/benchmark-table-wc/append/1k 481.15 (± 3.82ms) 512.18 (± 11.98ms) +31.0ms (6.4%)
wc-clear-1k.benchmark/benchmark-table-wc/clear/1k 21.45 (± 0.22ms) 26.64 (± 0.34ms) +5.2ms (24.2%)
wc-create-10k.benchmark/benchmark-table-wc/create/10k 2941.10 (± 24.02ms) 3204.47 (± 34.23ms) +263.4ms (9.0%)
wc-create-1k.benchmark/benchmark-table-wc/create/1k 331.37 (± 0.87ms) 368.19 (± 1.99ms) +36.8ms (11.1%)
wc-update-10th-1k.benchmark/benchmark-table-wc/update-10th/1k 113.83 (± 0.61ms) 131.40 (± 1.43ms) +17.6ms (15.4%)

@lwc/engine-server

✅ Improvements base (2342e57) target (cc82c57) trend
table-render-10k.benchmark/benchmark-table/render/10k 504.55 (± 18.37ms) 473.06 (± 14.72ms) -31.5ms (6.2%)

Copy link
Contributor

@jodarove jodarove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants