refactor(wire-service): wire decorator reform #1802
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Revert "feat: add wire config as function (#1455)" (#1601)"
This reverts commit 722979e.
rebase from master
Squashed commit of the following:
commit 0f00e08
Author: Jose David Rodriguez jodarove@gmail.com
Date: Thu Sep 19 23:13:15 2019 -0700
fix: rebase issues
fix: wire-reform tests (#1524)
When a wire parameter has invalid value (eg: foo..bar, foo.bar[3]) it should (ideally) resolve in a compilation error during validation phase.
This is not possible due that platform components may have a param definition which is invalid but passes compilation, and throwing at compile time would break such components.
In such cases where the param does not have proper notation, the config generated will use the bracket notation to match the current behavior (that most likely end up resolving that param as undefined).
fix: tests for wire reactive parameters
fix: unit test register and WireAdapter
fix: backward compability when adding config listener
fix: adding general tests for wire adapter
wip: address pr comments and lint errors
fix: reactivity of wire params (#1526)
fix: reactivity of wire params
wip: address review comments
and run performance
wip: trigger perf measures
fix: remove valueMutated pruning condition
fix: add componentValueObserved for consistency
fix: remove tf because of wired properties being track
before the wire reform.
fix: ensure component rerender in compat
fix: tf because registerDecorators happens before registerAdapter
Revert "fix: tf because registerDecorators happens before registerAdapter"
This reverts commit b2d1a89.
fix: rebase issues
fix: remove tests because wire defs is not part of the public api
of getComponentDef
fix: add test for inherited methods
fix: context in targets hierarchy
fix: add registerWireService for backward compability
it is a noop.
fix(engine): remove assertions added by mistake on rebase
fix: rebase conflicts
fix: lint errors
todos errors.
fix: add support for adapters that use wirecontextevent
fix: prefix wired element key with deprecated and remove
redundant options in descriptor
fix: relax adapterId validation to isExtensible
instead of instanceof Object.
In order to be able to register an adapterId, the only precondition needed is that adapterId is extensible. this commit changes the old validation that was doing instanceof Object.
fix: tf because of error message changed
fix: debounce config call when creating component with wire
also, adds an extra data for the wire decorator, indicating if it has dynamic parameters.
fix: incorrect api field config returned from getComponentDef
fix: address pr comments
fix: include 33b91a2 in the wire reform
fix: —strictFunctionTypes issues plus rebase leftovers
Revert "refactor(engine): Decouple createElement from engine internals (#1751)"
This reverts commit 1ea1d60.
Conflicts:
packages/@lwc/engine/src/framework/def.ts
packages/@lwc/engine/src/framework/hooks.ts
packages/@lwc/engine/src/framework/services.ts
packages/@lwc/engine/src/framework/upgrade.ts
packages/@lwc/engine/src/framework/vm.ts
packages/@lwc/engine/src/framework/wc.ts
packages/@lwc/wire-service/src/index.ts
packages/@lwc/wire-service/src/property-trap.ts
packages/@lwc/wire-service/src/wiring.ts