Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: hidden fields instead of internal fields (2) #1485

Merged
merged 9 commits into from
Aug 31, 2019
Merged

refactor: hidden fields instead of internal fields (2) #1485

merged 9 commits into from
Aug 31, 2019

Commits on Aug 27, 2019

  1. chore: package-unique keys for engine and synthetic shadow

    @ekashida
    ekashida committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    2d75d7d View commit details
    Browse the repository at this point in the history

  2. refactor: remove internal fields in favor of hidden fields

    @ekashida
    ekashida committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    f2adc93 View commit details
    Browse the repository at this point in the history

  3. fix: avoid returning boolean false when field undefined

    @ekashida
    ekashida committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    e52f953 View commit details
    Browse the repository at this point in the history

  4. test: use hidden fields instead of internal fields

    @ekashida
    ekashida committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    0a80473 View commit details
    Browse the repository at this point in the history

  5. refactor(synthetic-shadow): hidden fields instead of internal fields

    @ekashida
    ekashida committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    861a4c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. chore(synthetic-shadow): "unique" string keys

    @ekashida
    ekashida committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    2968a25 View commit details
    Browse the repository at this point in the history

  2. fix(engine): issue 1299 second attempt

    @caridy
    caridy committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    748008f View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. fix(engine): removing hasOwnProperty check

    @caridy
    caridy committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    4d5358e View commit details
    Browse the repository at this point in the history

  2. chore: revert changes for vm access by getComponentConstructor

    @ekashida
    ekashida committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    e90b104 View commit details
    Browse the repository at this point in the history