Skip to content

Commit 941ce71

Browse files
committed
fix: test due rebase
1 parent cfdf043 commit 941ce71

File tree

8 files changed

+35
-11
lines changed

8 files changed

+35
-11
lines changed

packages/@lwc/template-compiler/src/__tests__/fixtures/regression/slot-name-with-dash/expected.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,12 @@ function tmpl($api, $cmp, $slotset, $ctx) {
1313
api_slot(
1414
"secret-slot",
1515
stc0,
16-
[api_static_fragment($fragment1 || ($fragment1 = $hoisted1()), 2)],
16+
[
17+
api_static_fragment(
18+
$fragment1 || ($fragment1 = $hoisted1()),
19+
"@secret-slot:2"
20+
),
21+
],
1722
$slotset
1823
),
1924
];

packages/@lwc/template-compiler/src/__tests__/fixtures/slots/definition-sibiling-slot/expected.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,18 @@ function tmpl($api, $cmp, $slotset, $ctx) {
2727
api_slot(
2828
"other",
2929
stc1,
30-
[api_static_fragment($fragment1 || ($fragment1 = $hoisted1()), 3)],
30+
[
31+
api_static_fragment(
32+
$fragment1 || ($fragment1 = $hoisted1()),
33+
"@other:3"
34+
),
35+
],
3136
$slotset
3237
),
3338
api_slot(
3439
"",
3540
stc2,
36-
[api_static_fragment($fragment2 || ($fragment2 = $hoisted2()), 6)],
41+
[api_static_fragment($fragment2 || ($fragment2 = $hoisted2()), "@:6")],
3742
$slotset
3843
),
3944
]),

packages/@lwc/template-compiler/src/__tests__/fixtures/slots/definition-sibling-static/expected.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ function tmpl($api, $cmp, $slotset, $ctx) {
2222
api_slot(
2323
"",
2424
stc1,
25-
[api_static_fragment($fragment2 || ($fragment2 = $hoisted2()), 5)],
25+
[api_static_fragment($fragment2 || ($fragment2 = $hoisted2()), "@:5")],
2626
$slotset
2727
),
2828
]),

packages/@lwc/template-compiler/src/__tests__/fixtures/slots/definition/expected.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function tmpl($api, $cmp, $slotset, $ctx) {
1919
api_slot(
2020
"",
2121
stc1,
22-
[api_static_fragment($fragment1 || ($fragment1 = $hoisted1()), 3)],
22+
[api_static_fragment($fragment1 || ($fragment1 = $hoisted1()), "@:3")],
2323
$slotset
2424
),
2525
]),

packages/@lwc/template-compiler/src/__tests__/fixtures/slots/mixed-1/expected.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,18 @@ function tmpl($api, $cmp, $slotset, $ctx) {
4343
api_slot(
4444
"",
4545
stc2,
46-
[api_static_fragment($fragment4 || ($fragment4 = $hoisted4()), 10)],
46+
[api_static_fragment($fragment4 || ($fragment4 = $hoisted4()), "@:10")],
4747
$slotset
4848
),
4949
api_slot(
5050
"footer",
5151
stc3,
52-
[api_static_fragment($fragment5 || ($fragment5 = $hoisted5()), 13)],
52+
[
53+
api_static_fragment(
54+
$fragment5 || ($fragment5 = $hoisted5()),
55+
"@footer:13"
56+
),
57+
],
5358
$slotset
5459
),
5560
]),

packages/@lwc/template-compiler/src/__tests__/fixtures/slots/usage-named/expected.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,12 @@ function tmpl($api, $cmp, $slotset, $ctx) {
2222
api_slot(
2323
"test",
2424
stc1,
25-
[api_static_fragment($fragment1 || ($fragment1 = $hoisted1()), 3)],
25+
[
26+
api_static_fragment(
27+
$fragment1 || ($fragment1 = $hoisted1()),
28+
"@test:3"
29+
),
30+
],
2631
$slotset
2732
),
2833
]),

packages/@lwc/template-compiler/src/codegen/codegen.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,11 @@ export default class CodeGen {
501501
return expression as t.Expression;
502502
}
503503

504-
genHoistedElement(element: Element): t.Expression {
504+
genHoistedElement(element: Element, slotParentName?: string): t.Expression {
505+
const key =
506+
slotParentName !== undefined
507+
? `@${slotParentName}:${this.generateKey()}`
508+
: this.generateKey();
505509
const html = serializeStaticElement(element);
506510

507511
this.usedLwcApis.add(PARSE_FRAGMENT_METHOD_NAME);
@@ -537,7 +541,7 @@ export default class CodeGen {
537541
t.callExpression(t.identifier(`$hoisted${idx}`), [])
538542
)
539543
),
540-
t.literal(this.generateKey()),
544+
t.literal(key),
541545
]);
542546
}
543547
}

packages/@lwc/template-compiler/src/codegen/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ function transform(codeGen: CodeGen): t.Expression {
9595
res = codeGen.getSlot(element.slotName, databag, defaultSlot);
9696
} else {
9797
res = codeGen.staticNodes.has(element)
98-
? codeGen.genHoistedElement(element)
98+
? codeGen.genHoistedElement(element, slotParentName)
9999
: codeGen.genElement(name, databag, children);
100100
}
101101

0 commit comments

Comments
 (0)