Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(serializer): normalize class attributes #236

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix(serializer): normalize class attributes #236

merged 2 commits into from
Apr 8, 2024

Conversation

nolanlawson
Copy link
Contributor

@nolanlawson nolanlawson commented Apr 4, 2024 •
edited
Loading

Split into two commits to make the changes more obvious.

BREAKING CHANGE: snapshots may change.

TODO: do the same for style attrs.

W-15365974

@jmsjtu jmsjtu mentioned this pull request Apr 4, 2024
Merged
@jmsjtu
Copy link
Member

jmsjtu commented Apr 4, 2024

See #237 for style attribute changes.

@nolanlawson nolanlawson merged commit aa351cc into master Apr 8, 2024
10 checks passed
@nolanlawson nolanlawson deleted the nolan/repro-class-attr-and-fix branch April 8, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmsjtu jmsjtu jmsjtu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolanlawson @jmsjtu